-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/pedersen-commitments #1048
feature/pedersen-commitments #1048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really say anything about the correctness of the crypto itself, but I assume you and @aniampio verified it's correct.
There's couple of tiny changes that you might (or not) want to introduce.
Also, since it changes how our coconut works, do we want to be merging that into develop or should we keep it in separate branch? @futurechimp @mmsinclair ? Perhaps we could still merge it since coconut is not really used anywhere just yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Is there something specific that needs to be done when generating keys, using for example https://github.com/nymtech/coconut/tree/develop/keygen-cli ?
Replace original ElGamal encryption with Pedersen commitments for blind signatures.